Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Data Table: Optimize performance #2905

Merged
merged 3 commits into from
Feb 19, 2018
Merged

[ENH] Data Table: Optimize performance #2905

merged 3 commits into from
Feb 19, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Data Table is slow when it displays large a large table with large selection.

Description of changes
  • Avoid enumerating all QModenIndex's in the selection; use QItemSelectionRange's
  • Remove one proxying layer in favor of subclassing to minimize QModelIndex mappings.
  • Use Qt5 layout change hinting in TableModel.
Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak
Copy link
Member

Fantastic! Had problems with selection speed some time ago and this pull request solves them.

Before, selecting all elements took 3 second for adult and 4 minutes for one of my data sets (ca 16000 rows and 1500 columns). Now is seems instantaneous.

@markotoplak markotoplak merged commit 5043829 into biolab:master Feb 19, 2018
@lanzagar lanzagar added this to the 3.11 milestone Feb 23, 2018
@ales-erjavec ales-erjavec deleted the owtable-selection branch February 23, 2018 13:31
@astaric astaric mentioned this pull request Mar 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11
Development

Successfully merging this pull request may close these issues.
3 participants
@ales-erjavec @markotoplak @lanzagar